github-actions[bot] commented on code in PR #65206:
URL: https://github.com/apache/doris/pull/65206#discussion_r3628411436
##########
regression-test/suites/nereids_rules_p0/agg_strategy/distinct_agg_rewriter.groovy:
##########
@@ -38,17 +38,12 @@ suite("distinct_agg_rewriter") {
sql "set agg_phase=4"
sql "select group_concat(distinct dst_key1 order by dst_key2) from
t_gbykey_10_dstkey_10_1000_id group by gby_key"
- test {
- sql """select number % 2, count(distinct cast(number as varchar),
cast(number as varchar)),
- group_concat(distinct cast(number as varchar) order by number + 1)
from numbers('number'='10') group by number % 2"""
- exception "Unsupported query"
- }
- test {
- sql """select count(distinct cast(number as varchar), cast(number as
varchar)),
- group_concat(distinct cast(number as varchar) order by number + 1)
from numbers('number'='10')"""
- exception "Unsupported query"
- }
+ sql """select number % 2, count(distinct cast(number as varchar),
cast(number as varchar)),
Review Comment:
Make these result-checked regression cases. Both new statements are bare
`sql`, so the suite passes for any non-error output even though this PR changes
duplicate removal and the CountIf null-filtering expression. The Java tests
only inspect plan shape/input slots. Please use `qt_`/`order_qt_` with
generated expected counts, and include reordered/partially duplicated nullable
arguments so the grouped/global execution result is actually verified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
