Baymine commented on PR #65889: URL: https://github.com/apache/doris/pull/65889#issuecomment-5043755859
Thanks for the review! Addressed in ffd9b5bc289 — instead of skipping the dropped partition, `buildCacheTableForOlapScanNode` now throws when a selected partition is null. The enclosing `buildCacheTableList` catches it and falls back to `CacheMode.None`, so the query cache is bypassed for that query rather than built from an inconsistent partial partition set (which is also more consistent with the FE convention of failing fast rather than silently continuing). The NPE is still prevented, and the unit test now asserts the bypass behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
