nishant94 commented on code in PR #64667:
URL: https://github.com/apache/doris/pull/64667#discussion_r3629541557
##########
fe/fe-core/src/main/java/org/apache/doris/indexpolicy/IndexPolicy.java:
##########
@@ -69,7 +69,7 @@ public class IndexPolicy implements Writable,
GsonPostProcessable {
"empty", "char_replace", "icu_normalizer");
public static final Set<String> BUILTIN_ANALYZERS = ImmutableSet.of(
- "none", "standard", "unicode", "english", "chinese", "icu",
"basic", "ik");
+ "none", "standard", "unicode", "english", "chinese", "icu",
"basic", "ik", "kuromoji");
Review Comment:
The forward path is already guarded. At IndexPolicyMgr.createIndexPolicy
(line 158), rejects creating a custom analyzer whose name collides with a
builtin, so no new kuromoji custom analyzer can be created after this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
