github-actions[bot] commented on code in PR #65888:
URL: https://github.com/apache/doris/pull/65888#discussion_r3630892764
##########
run-regression-test.sh:
##########
@@ -23,6 +23,61 @@ ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")" &>/dev/null &&
pwd)"
DORIS_HOME="${ROOT}"
+java_major_version() {
+ local java_cmd="$1"
+ local spec_version
+
+ spec_version="$("${java_cmd}" -XshowSettings:properties -version 2>&1 \
Review Comment:
[P1] Normalize CRLF before the hard JDK check
On Cygwin, Java's CRLF settings output makes this parser return a value
ending in `\r`. `java_major_version` passes that through, so `is_jdk17_home`
rejects even a valid explicit JDK 17 and the script exits before Maven or
argument handling. The existing JDK helpers in `env.sh`, `start_be.sh`,
`start_fe.sh`, `run-be-ut.sh`, and `tools/find_libjvm.sh` already normalize
`\r` specifically for Cygwin. Please strip the carriage return before comparing
the major version, and cover CRLF input in the parser test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
