hello-stephen opened a new pull request, #65926: URL: https://github.com/apache/doris/pull/65926
### What problem does this PR solve? TeamCity S3 Docker build #203806 is the first real rerun after #64623. All 192 failed suites share one startup error: doris-compose up enters the new-cluster path and raises NameError because external_ms_cluster is passed to Cluster.new without initialization. The branch-4.1 backport already exposes --external-ms and persists the field in Cluster, but missed the initialization and validation block from master. #64623 fixed the preceding args.env error and therefore exposed this next failure in the same exception path. Jira: DORIS-26392 Build: http://172.20.48.17:8111/build/203806 ### What is changed? - Initialize external_ms_cluster for cloud and non-cloud new clusters. - Reuse an external MS/FDB cluster only after validating cluster type, nodes, and running containers. - Preserve the normal cloud path by explicitly setting the field to None. ### Check List - [x] git diff --check - [x] python3 -m py_compile docker/runtime/doris-compose/command.py docker/runtime/doris-compose/cluster.py - [ ] Rerun branch-4.1 Compile and S3 Docker after merge; all #203806 occurrences must create their clusters and reach their own assertions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
