github-actions[bot] commented on code in PR #65933:
URL: https://github.com/apache/doris/pull/65933#discussion_r3635127211
##########
regression-test/suites/demo_p0/test_flight_record.groovy:
##########
@@ -27,12 +27,29 @@ suite("test_flight_record", "nonConcurrent") {
return
}
+ // flightRecord starts the java flight recorder by the local jps/jcmd, so
it only works when the
+ // frontend runs on the same machine as the regression runner, e.g. a
local development cluster.
+ // Skip this demo when the frontend is not here, otherwise flightRecord
will fail the suite
+ String feProcessName = "DorisFE"
+ boolean feOnThisMachine = false
+ try {
+ feOnThisMachine = "jps".execute().text.readLines().any {
it.contains(feProcessName) }
Review Comment:
[P2] Please tie this gate to the configured frontend. Finding any local JVM
whose name contains `DorisFE` does not show that the FE in
`context.config.jdbcUrl` is local or is the PID that `FlightRecordAction` will
record. For example, with `remote-fe:9030` plus an unrelated local DorisFE on
port 9031, this passes, `getFePid` records that local JVM, and the body still
fails at `127.0.0.1:9030`; if an unrelated local FE owns port 9030, the case
can instead pass against the wrong cluster. Please make the eligibility check
and PID selection identify the same configured FE, or skip unless the suite can
establish that invariant unambiguously.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
