github-actions[bot] commented on code in PR #65964:
URL: https://github.com/apache/doris/pull/65964#discussion_r3642561834
##########
be/src/cloud/cloud_tablet_mgr.cpp:
##########
@@ -581,7 +581,7 @@ void CloudTabletMgr::get_topn_tablet_delete_bitmap_score(
buf.reserve(n + 1);
auto handler = [&](const std::weak_ptr<CloudTablet>& tablet_wk) {
auto t = tablet_wk.lock();
- if (!t) return;
+ if (!t || !t->enable_unique_key_merge_on_write()) return;
Review Comment:
[P2] Reset the gauges when the filtered set is empty
This filter makes a zero-result scan normal when no cached MoW tablets
remain, but `_check_tablet_delete_bitmap_score_callback()` only calls
`set_value()` when each maximum is greater than zero. After a MoW tablet
publishes a positive score and is then dropped or evicted, the next
non-MoW-only scan leaves both `/brpc_metrics` gauges stuck at the old values
indefinitely. Please publish both completed-scan values unconditionally
(including zero) and cover the positive-to-empty transition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
