deardeng opened a new pull request, #65994:
URL: https://github.com/apache/doris/pull/65994
Problem Summary: When the Thrift connection to FE is unstable, a partially
deserialized TShowVariableResult can contain variable rows with fewer than four
fields. SchemaVariablesScanner accessed fields 0 through 3 unconditionally and
could crash the BE process. Validate every row before accessing its fields and
return an InternalError asking the user to retry when the response is
incomplete.
### Release note
Fix a BE crash when scanning variables after receiving an incomplete FE
response; the query now returns an error asking the user to retry.
### Check List (For Author)
- Test: No need to test (cherry-picked an existing upstream fix; no
functional test was run)
- Behavior changed: Yes (an incomplete FE variable response now returns an
InternalError instead of crashing BE)
- Does this need documentation: No
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [x] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [x] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [x] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
