morrySnow commented on code in PR #65250:
URL: https://github.com/apache/doris/pull/65250#discussion_r3645047648
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/util/JoinUtils.java:
##########
@@ -414,23 +420,6 @@ public static List<Slot> getJoinOutput(JoinType joinType,
Plan left, Plan right,
case RIGHT_SEMI_JOIN:
case RIGHT_ANTI_JOIN:
return ImmutableList.copyOf(rightOutput);
- case LEFT_OUTER_JOIN:
- case ASOF_LEFT_OUTER_JOIN:
- return ImmutableList.<Slot>builder()
- .addAll(leftOutput)
- .addAll(applyNullable(rightOutput, true))
- .build();
- case RIGHT_OUTER_JOIN:
- case ASOF_RIGHT_OUTER_JOIN:
- return ImmutableList.<Slot>builder()
- .addAll(applyNullable(leftOutput, true))
- .addAll(rightOutput)
- .build();
- case FULL_OUTER_JOIN:
- return ImmutableList.<Slot>builder()
- .addAll(applyNullable(leftOutput, true))
- .addAll(applyNullable(rightOutput, true))
- .build();
Review Comment:
这块不要改了，直接枚举所有类型比较不容易出错
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
