github-actions[bot] commented on code in PR #66053: URL: https://github.com/apache/doris/pull/66053#discussion_r3651771323
########## .github/CODEOWNERS: ########## @@ -70,15 +70,15 @@ be/test/load/channel @liaoxin01 @gavinch be/test/load/delta_writer @liaoxin01 @gavinchou be/test/load/memtable @liaoxin01 @gavinchou be/test/olap @gavinchou -be/test/olap/rowset @gavinchou -be/test/storage @gavinchou +be/test/olap/rowset @gavinchou @yiguolei +be/test/storage @gavinchou @yiguolei Review Comment: Please also add `@yiguolei` to the later `be/test/storage/tablet` rule. CODEOWNERS uses the last matching pattern, so files such as `be/test/storage/tablet/tablet_test.cpp` are still owned only by `@gavinchou`; this newly broadened `be/test/storage` rule never applies to that subtree. A PR confined to these dedicated tablet tests therefore still cannot be covered by `@yiguolei`, leaving the stated tablet-test ownership goal incomplete. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
