github-actions[bot] commented on code in PR #65483:
URL: https://github.com/apache/doris/pull/65483#discussion_r3652203267


##########
gensrc/thrift/PaloInternalService.thrift:
##########
@@ -507,6 +507,7 @@ struct TQueryOptions {
   225: optional i64 runtime_filter_tree_publish_max_send_bytes = 268435456
 
   226: optional bool enable_prune_nested_column = false;
+  227: optional bool new_version_bitmap_op_count = false;

Review Comment:
   [P1] Preserve this flag in external query plans
   
   This flag is present when `TableQueryPlanAction` plans a single-table 
`LogicalProject`, but `TQueryPlanInfo` serializes only the fragment, descriptor 
table, tablet metadata, and query id. 
`FragmentMgr::exec_external_plan_fragment` later builds a fresh `TQueryOptions` 
without `new_version_bitmap_op_count`. For a projection such as 
`bitmap_count(bitmap_or(nullable_bitmap, bitmap_empty()))`, FE rewrites to 
non-null `BIGINT` `bitmap_or_count`, while BE selects the legacy builder and 
derives `Nullable(BIGINT)`; `FunctionBuilderImpl::build` then rejects the 
fragment before `open_scanner` returns rows. This is a same-version path and is 
separate from the coordinator and short-circuit cases already covered. Please 
carry the planner query options in the opaque external-plan envelope (keeping 
the field optional so old cached plans remain compatible) and add an 
external-plan test with a nullable bitmap projection.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to