xiaokang commented on code in PR #15918:
URL: https://github.com/apache/doris/pull/15918#discussion_r1069633257


##########
be/src/common/config.h:
##########
@@ -880,6 +880,8 @@ CONF_mDouble(inverted_index_ram_buffer_size, "512");
 CONF_Int32(query_bkd_inverted_index_limit_percent, "5"); // 5%
 // dict path for chinese analyzer
 CONF_String(inverted_index_dict_path, "${DORIS_HOME}/dict");
+// tree depth for bkd index
+CONF_Int32(max_depth_in_bkd_tree, "32");

Review Comment:
   unified conf prefix inverted_index is prefered



##########
be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:
##########
@@ -177,11 +195,8 @@ class InvertedIndexColumnWriterImpl : public 
InvertedIndexColumnWriter {
 
     void new_fulltext_field(const char* field_value_data, size_t 
field_value_size) {
         if (_parser_type == InvertedIndexParserType::PARSER_ENGLISH) {
-            //NOTE:if parser is english analyzer, just construct token stream 
to analyzer for efficiency.
             new_char_token_stream(field_value_data, field_value_size, _field);
         } else if (_parser_type == InvertedIndexParserType::PARSER_CHINESE) {
-            //NOTE:if parser is chinese analyzer, need to do 
utf8->unicode->wide_char

Review Comment:
   comment deleted by mistake



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to