CalvinKirs commented on code in PR #66004:
URL: https://github.com/apache/doris/pull/66004#discussion_r3654547679
##########
fe/fe-filesystem/fe-filesystem-jfs/src/main/java/org/apache/doris/filesystem/jfs/JfsFileSystemProvider.java:
##########
@@ -54,10 +53,43 @@ public boolean supports(Map<String, String> properties) {
}
@Override
- public FileSystem create(Map<String, String> properties) throws
IOException {
+ public JfsProperties bind(Map<String, String> properties) {
JfsProperties jfsProperties = new JfsProperties(properties);
jfsProperties.initNormalizeAndCheckProps();
- return new DFSFileSystem(jfsProperties.getBackendConfigProperties());
+ return jfsProperties;
+ }
+
+ @Override
+ public FileSystem create(JfsProperties properties) throws IOException {
+ return new DFSFileSystem(properties.getBackendConfigProperties());
Review Comment:
Fixed. The full legacy Kerberos model was lifted into
`HdfsCompatibleProperties` (fe-filesystem-hdfs-base) so HDFS and JFS share one
implementation: both alias families (`hdfs.authentication.*` and
`hadoop.security.authentication`/`hadoop.kerberos.*`) with legacy precedence,
the byte-identical missing-principal/keytab validation, the backend-map
translation (`hdfs.security.authentication`,
`ipc.client.fallback-to-simple-auth-allowed`, kerberos keys), and
Kerberos-vs-Simple authenticator selection — so
`StorageAdapter.getExecutionAuthenticator()` returns the Kerberos authenticator
for `jfs://` again, covering the direct create path and the Iceberg/Paimon
metastore consumers. This also restored two keys the first port had dropped
from JFS's simple-case backend map. OSS-HDFS was audited against the legacy
oracle and never had kerberos handling, so it is unchanged. Tests:
`HdfsCompatiblePropertiesAuthTest` (new), JFS kerberos cases for both alias
families + missing-credential valida
tion, and golden backend-map parity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
