HappenLee opened a new pull request, #66102:
URL: https://github.com/apache/doris/pull/66102
### What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary:
Nullable aggregation hash tables marked the null-key entry as present before
its aggregate state creator completed. If memory allocation or aggregate-state
creation threw, cleanup treated the uninitialized null-key state as valid and
could crash while destroying it.
This change publishes the null-key flag only after successful creation,
value-initializes null-key storage, and applies the same exception-safe
ordering to the StringHashMap batch fast paths. Regression tests cover mapped,
void, and batch StringHashMap creation failures followed by successful retry.
### Release note
Fix a BE crash when nullable aggregation state creation fails under memory
pressure.
### Check List (For Author)
- Test: Unit Test added
- ASAN_UT test object compiled successfully
- clang-tidy passed
- clang-format and check-format passed
- Behavior changed: Yes. Failed null-key state creation is no longer
published as a valid hash entry.
- Does this need documentation: No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
