github-actions[bot] commented on code in PR #66093: URL: https://github.com/apache/doris/pull/66093#discussion_r3656100173
########## regression-test/data/row_binlog_p0/test_row_binlog_cluster_key.out: ########## @@ -0,0 +1,8 @@ +-- This file is automatically generated. You should know what you did if you want to edit this +-- !effective_row_binlog_properties -- +binlog.enable true +binlog.format ROW + +-- !show_create_without_random_cluster_key -- +test_row_binlog_without_cluster_key CREATE TABLE `test_row_binlog_without_cluster_key` (\n `id` bigint NOT NULL,\n `cluster_value` int NOT NULL,\n `payload` varchar(32) NOT NULL\n) ENGINE=OLAP\nUNIQUE KEY(`id`)\nDISTRIBUTED BY HASH(`id`) BUCKETS 1\nPROPERTIES (\n"replication_allocation" = "tag.location.default: 1",\n"min_load_replica_num" = "-1",\n"is_being_synced" = "false",\n"storage_medium" = "hdd",\n"storage_format" = "V2",\n"inverted_index_storage_format" = "V3",\n"enable_unique_key_merge_on_write" = "true",\n"light_schema_change" = "true",\n"disable_auto_compaction" = "false",\n"group_commit_interval_ms" = "10000",\n"group_commit_data_bytes" = "134217728",\n"enable_mow_light_delete" = "false"\n); Review Comment: Please regenerate this result with the suite's standard FE configuration. Both p0 and `nonConcurrent` set `enable_feature_binlog=true`, and `Env.getDdlStmt` then appends the effective binlog config to `SHOW CREATE`. This table is `enable=true`/`ROW`, so the actual row includes the binlog enable, TTL, size/history, format, and historical-value properties; this golden omits all of them and will not match CI. This is distinct from the earlier missing-`.out` comment: the artifact now exists, but it was generated against the wrong FE configuration. ########## regression-test/suites/row_binlog_p0/test_row_binlog_cluster_key.groovy: ########## @@ -0,0 +1,87 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +suite("test_row_binlog_cluster_key", "nonConcurrent") { + if (isCloudMode()) { + return + } + + def inheritedBinlogDb = "test_row_binlog_cluster_key_db" + + sql "DROP TABLE IF EXISTS test_row_binlog_cluster_key FORCE" + sql "DROP DATABASE IF EXISTS ${inheritedBinlogDb} FORCE" + sql "CREATE DATABASE ${inheritedBinlogDb}" + sql """ + ALTER DATABASE ${inheritedBinlogDb} SET PROPERTIES ( + "binlog.enable" = "false", + "binlog.format" = "ROW" + ) + """ + + setFeConfigTemporary([random_add_order_by_keys_for_mow: true]) { + test { + sql """ + CREATE TABLE test_row_binlog_cluster_key ( + id BIGINT NOT NULL, + cluster_value INT NOT NULL, + payload VARCHAR(32) NOT NULL + ) + UNIQUE KEY(id) + ORDER BY(cluster_value) + DISTRIBUTED BY HASH(id) BUCKETS 1 + PROPERTIES ( + "replication_num" = "1", + "enable_unique_key_merge_on_write" = "true", + "light_schema_change" = "true", + "binlog.enable" = "true", + "binlog.format" = "ROW" + ) + """ + exception "Unique merge-on-write tables with cluster keys do not support binlog<Row>" + } + + sql """ + CREATE TABLE ${inheritedBinlogDb}.test_row_binlog_without_cluster_key ( + id BIGINT NOT NULL, + cluster_value INT NOT NULL, + payload VARCHAR(32) NOT NULL + ) + UNIQUE KEY(id) + DISTRIBUTED BY HASH(id) BUCKETS 1 + PROPERTIES ( Review Comment: Please pin `storage_format` (for example, `"storage_format" = "V2"`) in this successful CREATE before using its full `SHOW CREATE` output as a golden. The `nonConcurrent` pipeline enables fuzzy session variables; each connection randomly sets `useV3StorageFormat`, and `CreateTableInfo.validate` injects V3 whenever this property is absent. The committed `.out` hardcodes V2, so this case will otherwise fail nondeterministically. Regenerate the golden after pinning the format. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
