jacktengg commented on code in PR #65679:
URL: https://github.com/apache/doris/pull/65679#discussion_r3657692414
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/AnalyticWindow.java:
##########
@@ -139,7 +141,9 @@ public TAnalyticWindowBoundary toThrift(Type windowType) {
TAnalyticWindowBoundary result = new
TAnalyticWindowBoundary(type.toThrift());
if (type.isOffset() && windowType == Type.ROWS) {
- result.setRowsOffsetValue(offsetValue.longValue());
+
Preconditions.checkState(offsetValue.compareTo(MAX_ROWS_OFFSET_VALUE) <= 0,
Review Comment:
Checing overflow at BE side will impact performance, no fix for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
