Doris-Breakwater commented on issue #66138: URL: https://github.com/apache/doris/issues/66138#issuecomment-5098789908
Breakwater-GitHub-Analysis-Slot: slot_57457c01c68d Initial assessment: this is not currently evidence of a missing Doris 4.0.6 implementation, and no next-release code change is indicated yet. In the exact `4.0.6` tag, `ignore_backup_tmp_partitions` already exists as a mutable, master-only **FE configuration**, and `BackupHandler` reads it when validating tables that contain temporary partitions: - [`Config.java`](https://github.com/apache/doris/blob/4.0.6/fe/fe-common/src/main/java/org/apache/doris/common/Config.java#L1750-L1757) - [`BackupHandler.java`](https://github.com/apache/doris/blob/4.0.6/fe/fe-core/src/main/java/org/apache/doris/backup/BackupHandler.java#L516-L529) - [The 4.0.6 regression case](https://github.com/apache/doris/blob/4.0.6/regression-test/suites/backup_restore/test_backup_restore_backup_temp_partition.groovy#L60-L85) The reported `Unknown system variable 'ignore_backup_tmp_partitions'` message is emitted by the session/system-variable path when a normal `SET [SESSION|GLOBAL] ...` (or `@@...` lookup) cannot find the name. That path is separate from FE configuration handling. Therefore, the statement that produced this particular error treated the name as a system variable; the error occurs before backup validation and does not show that `BackupHandler` failed to read the FE configuration. Please use the FE-configuration syntax with an account that has `ADMIN` privilege: ```sql SHOW FRONTEND CONFIG LIKE 'ignore_backup_tmp_partitions'; ADMIN SET FRONTEND CONFIG ('ignore_backup_tmp_partitions' = 'true'); SHOW FRONTEND CONFIG LIKE 'ignore_backup_tmp_partitions'; ``` This option is master-only, and the supported `ADMIN SET FRONTEND CONFIG` command forwards it to the master FE. The SQL command changes the runtime value; for restart persistence, put `ignore_backup_tmp_partitions = true` in the effective FE configuration on the FE nodes. Note that `${custom_config_dir}/fe_custom.conf`, if present, is loaded after `fe.conf` and can override it. Verify the effective value rather than relying only on the file contents. Semantics to keep in mind: - When the value is `true`, temporary partitions are omitted from the snapshot; they are not backed up or restored. - `EXCLUDE (table_name, ...)` excludes whole tables. It does not exclude temporary partitions inside an otherwise included table. If the table containing temporary partitions is correctly excluded, that table is removed from the backup object list before temporary-partition validation. If the backup still fails after the second `SHOW FRONTEND CONFIG` returns `true`, please provide: 1. The exact statement that raises the unknown-variable error and the exact redacted `BACKUP ...` statement, including the `ON` or `EXCLUDE` clause. 2. Output of `SELECT VERSION();`, `SHOW FRONTENDS;` (hosts may be redacted, but retain role/master information), and `SHOW FRONTEND CONFIG LIKE 'ignore_backup_tmp_partitions';` immediately before the backup. 3. Minimal DDL to create the affected table and temporary partition, plus `SHOW TEMPORARY PARTITIONS FROM <db>.<table>;`. 4. The FE audit/`fe.log` entries and query ID for the configuration statement and failed backup. If configuration was changed in files, also identify the effective `fe.conf`/`fe_custom.conf` paths and whether the relevant FE processes were restarted. Suggested maintainer action: classify this as needs-information / likely configuration-syntax mismatch and ask the reporter to run the commands above. Reconsider it as a 4.0.6 backup bug only if the effective master FE value is demonstrably `true` and a minimal backup still rejects temporary partitions, or if a correctly named table in `EXCLUDE` is still validated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
