github-actions[bot] commented on code in PR #65679:
URL: https://github.com/apache/doris/pull/65679#discussion_r3662268203
##########
fe/fe-core/src/test/java/org/apache/doris/nereids/rules/rewrite/CheckAndStandardizeWindowFunctionTest.java:
##########
@@ -239,7 +239,7 @@ public void testCheckWindowFrameBeforeFunc5() {
WindowFrame windowFrame2 = new WindowFrame(FrameUnitsType.ROWS,
FrameBoundary.newFollowingBoundary(new IntegerLiteral(5)),
FrameBoundary.newFollowingBoundary(new IntegerLiteral(4)));
- String errorMsg2 = "WindowFrame with FOLLOWING boundary requires that
leftBoundOffset >= rightBoundOffset";
+ String errorMsg2 = "WindowFrame with FOLLOWING boundary requires that
leftBoundOffset <= rightBoundOffset";
Review Comment:
[P2] Exercise the precision-sensitive frame-order predicate.
The selected `5`/`4` offsets exercise the corrected error text, but they do
not distinguish the previous `double` predicate from the new `BigDecimal`
predicate. Adjacent offsets such as `9223372036854775807` and
`9223372036854775806` collapse to the same `double`; before this patch, an
invalid `ROWS BETWEEN 9223372036854775807 FOLLOWING AND 9223372036854775806
FOLLOWING` frame could therefore pass this check. Because no active regression
exercises two near-int64 frame bounds, a predicate-only regression back to
`double` would go undetected. Please add adjacent near-`Long.MAX_VALUE`
PRECEDING/FOLLOWING ordering coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
