Copilot commented on code in PR #66140:
URL: https://github.com/apache/doris/pull/66140#discussion_r3662280897
##########
fe/pom.xml:
##########
@@ -284,6 +284,7 @@ under the License.
<mqtt.version>1.2.5</mqtt.version>
<slf4j.version>2.0.17</slf4j.version>
<metrics-core.version>4.0.2</metrics-core.version>
+ <resilience4j.version>2.4.0</resilience4j.version>
Review Comment:
Resilience4j 2.x requires a Java 17+ runtime, but this module is still
configured to compile for Java 8 (maven.compiler.source/target=1.8). Pulling in
resilience4j-ratelimiter at 2.4.0 will fail on Java 8 runtimes (and will also
fail builds if they run on JDK 8). Either bump the FE Java baseline/toolchain
accordingly, or use a Resilience4j 1.x line that remains Java 8 compatible.
##########
fe/fe-core/src/main/java/org/apache/doris/common/profile/SummaryProfile.java:
##########
@@ -1088,14 +1106,18 @@ public long getGetPartitionVersionByHasDataCount() {
return getPartitionVersionByHasDataCount;
}
- public long getGetTableVersionTime() {
- return getTableVersionTime;
+ public long getGetTableVersionTimeMs() {
+ return TimeUnit.NANOSECONDS.toMillis(getTableVersionTime);
}
public long getGetTableVersionCount() {
return getTableVersionCount;
}
+ public long getGetMetaVersionRateLimitWaitTime() {
+ return getMetaVersionRateLimitWaitTime;
+ }
Review Comment:
This new getter returns a duration in nanoseconds (it is accumulated from ns
values and later converted to ms in getMetaTime), but the method name does not
indicate its unit. This is easy to misuse, especially now that nearby getters
were renamed to *TimeMs(). Consider renaming to include the unit (e.g.
...WaitTimeNs) and/or adding a corresponding ...WaitTimeMs() getter for
consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
