csun5285 commented on code in PR #66048:
URL: https://github.com/apache/doris/pull/66048#discussion_r3662685834
##########
be/src/storage/rowset/beta_rowset_writer.cpp:
##########
@@ -200,12 +201,15 @@ Status SegmentFileCollection::close() {
<< " after_state=" << static_cast<int>(writer->state());
});
if (writer->state() != io::FileWriter::State::CLOSED) {
- RETURN_IF_ERROR(writer->close());
+ auto status = writer->close();
Review Comment:
这种第一个就可以返回失败了，后面的writer 靠析构是不是就可以了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
