github-actions[bot] commented on code in PR #66083:
URL: https://github.com/apache/doris/pull/66083#discussion_r3663692089
##########
fe/fe-core/src/main/java/org/apache/doris/planner/OlapTableSink.java:
##########
@@ -1169,17 +1169,32 @@ public List<TOlapTableLocationParam>
createDummyLocation(OlapTable table) throws
final long fakeTabletId = 0;
SystemInfoService clusterInfo = Env.getCurrentSystemInfo();
- List<Long> aliveBe = clusterInfo.getAllBackendIds(true);
- if (aliveBe.isEmpty()) {
+ List<Backend> currentComputeGroupBackends;
+ if (Config.isCloudMode()) {
+ ConnectContext context = ConnectContext.get();
+ if (context == null) {
+ throw new UserException("connect context is null when creating
dummy location");
+ }
+ currentComputeGroupBackends = ((CloudSystemInfoService)
clusterInfo)
+ .getBackendsByClusterName(context.getCloudCluster());
Review Comment:
[P1] Keep in-flight load targets stable across compute-group renames
`StreamLoadHandler` derives a mutable group name from the request's stable
backend ID before planning, and cloud broker jobs similarly convert their
persisted `cloudClusterId` to a name before `task.init()`. If a rename removes
that name before this lookup, an empty automatic-partition stream load returns
`INTERNAL_ERROR`. In a multi-key broker load, if an earlier loading task
initialized before a later task hits this lookup, the earlier task is already
registered but none have been submitted; `onTaskFailed()` then waits forever
for that task's `done` flag, leaving the job in `RETRY` and the scheduler
worker blocked. The target ID still exists, and the old dummy lookup was
name-independent. Atomically resolve and pass a stable ID/backend snapshot
before planning, and add latch-based stream and multi-task broker rename tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
