Copilot commented on code in PR #66137:
URL: https://github.com/apache/doris/pull/66137#discussion_r3664306463
##########
be/src/cloud/cloud_warm_up_manager.cpp:
##########
@@ -94,6 +94,10 @@ bvar::Status<int64_t>
g_file_cache_warm_up_rowset_last_call_unix_ts(
"file_cache_warm_up_rowset_last_call_unix_ts", 0);
bvar::Adder<uint64_t> file_cache_warm_up_failed_task_num("file_cache_warm_up",
"failed_task_num");
bvar::Adder<uint64_t>
g_balance_tablet_be_mapping_size("balance_tablet_be_mapping_size");
+// Number of warm up jobs currently held in this BE's memory.
+// Incremented when FE dispatches a new job to this BE (SET_JOB / SET_BATCH /
event SET_JOB),
+// decremented when the job is cleared (CLEAR_JOB / event CLEAR_JOB).
Review Comment:
The comment mentions "event SET_JOB / event CLEAR_JOB", but the event-driven
path here is keyed off `TWarmUpEventType::LOAD` (SET_JOB/CLEAR_JOB requests
with `__isset.event`). Updating the wording avoids confusion for operators/devs
reading the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
