hubgeter commented on code in PR #65851:
URL: https://github.com/apache/doris/pull/65851#discussion_r3669023797
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/iceberg/source/IcebergScanNode.java:
##########
@@ -505,22 +524,63 @@ private List<String> getOrderedPathPartitionKeys() {
}
public void createScanRangeLocations() throws UserException {
- super.createScanRangeLocations();
+ Schema scanSchema = getQuerySchema();
+ Set<Integer> equalityDeleteFieldIds = Collections.emptySet();
+ if (!isSystemTable) {
+ equalityDeleteFieldIds = getEqualityDeleteFieldIdsForScan();
+ boolean requiresCurrentSemantics =
requiresRecursiveInitialDefaultMaterialization(
+ scanSchema, desc.getSlots()) ||
!equalityDeleteFieldIds.isEmpty();
Review Comment:
Fixed in 6c6ac29105d. FE now recursively detects, at every struct nested
through struct/list/map, when one field historical alias collides
case-insensitively with a different sibling current name. Such scans require
current Iceberg scan semantics and reject smooth-upgrade source BEs before scan
planning. The mixed-version planner test covers the renamed ARRAY alias payload
plus replacement MAP payload case, while confirming current BEs remain eligible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
