github-actions[bot] commented on code in PR #66201:
URL: https://github.com/apache/doris/pull/66201#discussion_r3670506477


##########
.asf.yaml:
##########
@@ -192,7 +192,9 @@ github:
   collaborators:
     - Yukang-Lian
     - Hastyshell
+    - yujun777

Review Comment:
   **Include `ixzc` in the invitation-renewal cycle.** This head is a valid 
phase-two delta for the two added names, but it leaves the third missing 
collaborator identified in [the #66165 
thread](https://github.com/apache/doris/pull/66165#discussion_r3665097766) 
unchanged. ASF's 
[handler](https://github.com/apache/infrastructure-asfyaml/blob/fff9963d2f8e73e3cc9da503f3ca2daeb9cddbd4/asfyaml/feature/github/collaborators.py#L46-L64)
 computes `to_add = new_collabs - old_collabs`; because `ixzc` is present in 
both the base and head, it will add only `yujun777` and `feiniaofeiafei`. The 
current direct-collaborator API still omits `ixzc`, whose role remains public 
`read` rather than direct `triage`. Please remove `ixzc` in this push while 
re-adding the other two, then re-add it in a separate later push; 
alternatively, remove `ixzc` from the list and document that it should no 
longer receive `triage`, or ask ASF Infrastructure to reconcile it. Removing 
and re-adding it within one push would 
 still leave the final set unchanged and make no API call.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to