github-actions[bot] commented on code in PR #66197:
URL: https://github.com/apache/doris/pull/66197#discussion_r3670597873
##########
fe/fe-core/src/main/java/org/apache/doris/cloud/alter/CloudSchemaChangeHandler.java:
##########
@@ -370,6 +370,8 @@ public void updateTableProperties(Database db, String
tableName, Map<String, Str
param.type =
UpdatePartitionMetaParam.TabletMetaType.ENABLE_MOW_LIGHT_DELETE;
} else if
(properties.containsKey(PropertyAnalyzer.PROPERTIES_AUTO_ANALYZE_POLICY)) {
// Do nothing.
+ } else if
(properties.containsKey(PropertyAnalyzer.PROPERTIES_PARTITION_RETENTION_COUNT))
{
Review Comment:
[P1] Reject retention count when dynamic partitioning is enabled
This branch only checks that the table is AUTO RANGE, so a cloud table with
dynamic_partition.enable=true can now add partition.retention_count. Creation
and the reverse ALTER explicitly reject that combination, but after this path
persists both values DynamicPartitionScheduler gives retention precedence, sets
skipAddPartition, and silently stops generating the configured dynamic
partitions while the table still advertises them as enabled. Please enforce the
same mutual-exclusion check before persisting the count (ideally in shared
validation), and add a cloud-selected regression for the dynamic-first
ordering. The cited backup_restore suite is excluded from the cloud P0/P1
pipelines, so it does not exercise this branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
