github-actions[bot] commented on code in PR #66154:
URL: https://github.com/apache/doris/pull/66154#discussion_r3672872029
##########
fe/fe-core/src/main/java/org/apache/doris/cloud/catalog/CloudReplica.java:
##########
@@ -66,7 +66,6 @@ public class CloudReplica extends Replica implements
GsonPostProcessable {
// last time to get tablet stats
@Getter
@Setter
- @SerializedName(value = "gst")
long lastGetTabletStatsTime = 0;
Review Comment:
Please add direct compatibility coverage for this persistence change.
Removing `@SerializedName` is what makes Doris's production Gson omit these
scheduler fields; ignoring old `gst`/`sii` values and defaulting both fields to
zero is also what makes the first post-restart refresh run. The generic Gson
tests prove the annotation policy, but no test binds it to the `CloudReplica`
runtime subtype or these legacy keys, so either behavior can regress while the
current suite stays green. A focused production-adapter test should set both
fields nonzero, assert new JSON omits both compact and Java names, then load
legacy JSON containing nonzero `gst`/`sii` and assert both scheduling values
reset to zero while ordinary replica statistics survive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
