github-actions[bot] commented on code in PR #15663:
URL: https://github.com/apache/doris/pull/15663#discussion_r1071032157
##########
be/src/vec/olap/vcollect_iterator.h:
##########
@@ -72,6 +72,26 @@ class VCollectIterator {
}
private:
+ // next for topn query
+ Status topn_next(Block* block);
+
+ class BlockRowposComparator {
+ public:
+ BlockRowposComparator(MutableBlock* mutable_block,
+ const std::vector<uint32_t>* compare_columns,
bool is_reverse)
+ : _mutable_block(mutable_block),
+ _compare_columns(compare_columns),
+ _is_reverse(is_reverse) {}
+
+ bool operator()(const size_t& lpos, const size_t& rpos) const;
+
+ private:
+ const MutableBlock* _mutable_block = nullptr;
+ const std::vector<uint32_t>* _compare_columns;
+ // reverse the compare order
+ const bool _is_reverse = false;
Review Comment:
warning: private field '_is_reverse' is not used
[clang-diagnostic-unused-private-field]
```cpp
const bool _is_reverse = false;
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
