adonis0147 commented on code in PR #15972: URL: https://github.com/apache/doris/pull/15972#discussion_r1071307921
########## be/src/olap/rowset/segment_v2/bitshuffle_wrapper.cpp: ########## @@ -34,6 +34,15 @@ #undef bshuf_compress_lz4 #undef bshuf_decompress_lz4 +#undef BITSHUFFLE_H +#define bshuf_compress_lz4_bound bshuf_compress_lz4_bound_avx512 +#define bshuf_compress_lz4 bshuf_compress_lz4_avx512 +#define bshuf_decompress_lz4 bshuf_decompress_lz4_avx512 +#include <bitshuffle/bitshuffle.h> // NOLINT(*) +#undef bshuf_compress_lz4_bound +#undef bshuf_compress_lz4 +#undef bshuf_decompress_lz4 + Review Comment: > it is for two versions (avx2 and avx512) to make it run selectively according to platform features. It was old tricky (avx2 vs non-avx2), is it ? Okay, I see. I think you would better add comments like [L26](https://github.com/apache/doris/blob/ce4c8a710de456c9e919817ab7e8b59086a3726c/be/src/olap/rowset/segment_v2/bitshuffle_wrapper.cpp#L26). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
