This is an automated email from the ASF dual-hosted git repository.
mymeiyi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 5f4e295ca45 [improve](cloud) Skip non-MOW tablets for
get_topn_tablet_delete_bitmap_score (#65964)
5f4e295ca45 is described below
commit 5f4e295ca453c2b673d13d8ecb74b18046953800
Author: meiyi <[email protected]>
AuthorDate: Thu Jul 30 12:04:45 2026 +0800
[improve](cloud) Skip non-MOW tablets for
get_topn_tablet_delete_bitmap_score (#65964)
Problem Summary: CloudTabletMgr included non-MOW tablets when
calculating the top-N delete bitmap score. Skip non-MOW tablets before
reading and aggregating delete bitmap counts so the reported score only
represents MOW tables.
---
be/src/cloud/cloud_storage_engine.cpp | 10 +++-------
be/src/cloud/cloud_tablet_mgr.cpp | 2 +-
2 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/be/src/cloud/cloud_storage_engine.cpp
b/be/src/cloud/cloud_storage_engine.cpp
index 0dc8321c2c4..ae9943ff32d 100644
--- a/be/src/cloud/cloud_storage_engine.cpp
+++ b/be/src/cloud/cloud_storage_engine.cpp
@@ -1296,13 +1296,9 @@ void
CloudStorageEngine::_check_tablet_delete_bitmap_score_callback() {
uint64_t max_base_rowset_delete_bitmap_score = 0;
tablet_mgr().get_topn_tablet_delete_bitmap_score(&max_delete_bitmap_score,
&max_base_rowset_delete_bitmap_score);
- if (max_delete_bitmap_score > 0) {
-
_tablet_max_delete_bitmap_score_metrics->set_value(max_delete_bitmap_score);
- }
- if (max_base_rowset_delete_bitmap_score > 0) {
- _tablet_max_base_rowset_delete_bitmap_score_metrics->set_value(
- max_base_rowset_delete_bitmap_score);
- }
+
_tablet_max_delete_bitmap_score_metrics->set_value(max_delete_bitmap_score);
+ _tablet_max_base_rowset_delete_bitmap_score_metrics->set_value(
+ max_base_rowset_delete_bitmap_score);
}
}
diff --git a/be/src/cloud/cloud_tablet_mgr.cpp
b/be/src/cloud/cloud_tablet_mgr.cpp
index 3e979864138..0c067a463af 100644
--- a/be/src/cloud/cloud_tablet_mgr.cpp
+++ b/be/src/cloud/cloud_tablet_mgr.cpp
@@ -581,7 +581,7 @@ void CloudTabletMgr::get_topn_tablet_delete_bitmap_score(
buf.reserve(n + 1);
auto handler = [&](const std::weak_ptr<CloudTablet>& tablet_wk) {
auto t = tablet_wk.lock();
- if (!t) return;
+ if (!t || !t->enable_unique_key_merge_on_write()) return;
uint64_t delete_bitmap_count =
t.get()->tablet_meta()->delete_bitmap().get_delete_bitmap_count();
total_delete_map_count += delete_bitmap_count;
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
