github-actions[bot] commented on code in PR #65839:
URL: https://github.com/apache/doris/pull/65839#discussion_r3679981053
##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -1648,6 +1650,15 @@ public enum IgnoreSplitType {
"Whether to force to local shuffle on pipelineX
engine."})
private boolean forceToLocalShuffle = false;
+ @VariableMgr.VarAttr(
+ name = BUCKET_SHUFFLE_DOWNGRADE_RATIO, fuzzy = false, varType =
VariableAnnotation.EXPERIMENTAL,
Review Comment:
Please reject non-finite values for this ratio. `VariableMgr` parses doubles
with `Double.parseDouble`, so `SET ... = 'NaN'` is accepted; in
`isBucketShuffleDownGrade`, both `NaN <= 0` and the subsequent `< ... * NaN`
comparison are false, silently disabling the downgrade even though the contract
says only values `<= 0` do that. The accepted value is also eligible for GLOBAL
SET and FE forwarding. Please add a checker that rejects NaN/infinity (as
`checkAnnIndexCandidateRowsPercentThreshold` already does) and cover that
validation along with the finite zero/default cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
