github-actions[bot] commented on code in PR #66224:
URL: https://github.com/apache/doris/pull/66224#discussion_r3680121816
##########
be/src/service/http/action/stream_load.cpp:
##########
@@ -330,17 +333,19 @@ Status StreamLoadAction::_on_header(HttpRequest*
http_req, std::shared_ptr<Strea
if ((ctx->format == TFileFormatType::FORMAT_JSON) &&
(ctx->body_bytes > json_max_body_bytes) && !read_json_by_line) {
return Status::Error<ErrorCode::EXCEEDED_LIMIT>(
- "json body size {} exceed BE's conf
`streaming_load_json_max_mb` {}. increase "
- "it if you are sure this load is reasonable",
- ctx->body_bytes, json_max_body_bytes);
+ "json body size {:.2f} MiB exceeds the limit of {} MiB set
by BE's conf "
Review Comment:
The byte comparison is exact, but `{:.2f}` can round away the excess that
triggered it. With a 100 MiB limit, `Content-Length: 104857601` is rejected
while this renders `100.00 MiB exceeds the limit of 100 MiB`; the CSV branch
and `HttpStreamAction` have the same issue. Please retain the exact byte count
(for example alongside the friendly MiB value), or use a rendering policy that
cannot display an over-limit value as equal, and add limit-plus-one coverage
for all three paths.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
