deardeng commented on code in PR #66235:
URL: https://github.com/apache/doris/pull/66235#discussion_r3681217538
##########
fe/fe-core/src/main/java/org/apache/doris/cloud/datasource/CloudInternalCatalog.java:
##########
@@ -216,6 +235,92 @@ protected Partition createPartitionWithIndices(long dbId,
OlapTable tbl, long pa
return partition;
}
+ public OlapFile.TabletMetaCloudPB getTabletMeta(long tabletId) throws
DdlException {
Review Comment:
[major/P1] Avoid issuing one synchronous Meta Service RPC per partition
while holding the table write lock.
collectPartitionInvertedIndexFileStorageFormats() performs
O(partition_count) sequential GetTablet RPCs under olapTable.writeLock. For
tables with thousands of partitions, the ALTER can hold the table metadata lock
for a long time. Any RPC failure aborts the operation before journaling, and
retrying starts the full scan again. Meta Service rate limiting only turns this
into latency or failure and does not make the operation scalable. Please batch
the tablet-meta reads and perform network I/O outside the table write lock,
then reacquire the lock and validate that the table/partition metadata has not
changed before committing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
