ccl125 commented on PR #66050: URL: https://github.com/apache/doris/pull/66050#issuecomment-5129022610
Thanks for the thorough scan! All five points are addressed in 1ca8dcf (pushed): 1. **2-arg regression** — the out-of-range error now only applies to the explicit three-argument form; two-argument calls on patterns without capturing groups keep the legacy empty-result behavior (covered by a ported unit case). 2. **Truncated pattern literal** — fixed, the string is 11 bytes. 3. **Dropped test table** — the column-input cases now recreate `test_string_function_regexp` before running. 4. **re2 advancing** — the loop now advances via the match pointer offset instead of a textual `find` (this and the next one were pre-existing issues in `match_all_and_extract`, fixed here since the function was being reworked anyway; regression case added). 5. **boost zero-width advancing** — now advances from `matches[0].first + 1` instead of the old origin. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
