wenzhenghu commented on code in PR #65126:
URL: https://github.com/apache/doris/pull/65126#discussion_r3683594628
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/RefreshManager.java:
##########
@@ -110,6 +110,13 @@ public void replayRefreshDb(ExternalObjectLog log) {
}
if (!db.isPresent()) {
+ if (!Strings.isNullOrEmpty(log.getDbName())) {
Review Comment:
Thank you. This has been fixed in commit `ac51e07dc10`.
Replay now resolves the retained local database name through a cache-only
`getDbNameForReplay(dbId)` helper when handling legacy ID-only logs. If the
database object is cold:
- an ID-only database refresh invalidates the engine database scope and any
already-initialized connector caches;
- an ID-only table refresh conservatively invalidates the database scope
because the cold database object makes its table-ID mapping unreachable;
- the fallback does not initialize the catalog/connector or perform remote
metadata I/O.
The FE tests cover TTL-zero database-object caches for both legacy database
and table refresh records. They also cover the hot-database/cold-table plugin
path and the missing retained-mapping degradation path. `RefreshManagerTest`
passes all 11 tests, and FE checkstyle passes with no violations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
