github-actions[bot] commented on code in PR #66221:
URL: https://github.com/apache/doris/pull/66221#discussion_r3688603712


##########
.github/workflows/be-ut-mac.yml:
##########
@@ -101,6 +126,19 @@ jobs:
               -o doris-thirdparty-prebuilt-darwin-arm64.tar.xz
           fi
           tar -xvf doris-thirdparty-prebuilt-darwin-arm64.tar.xz
+
+          # Rebuild the Arrow/Paimon stack when its dedicated inputs or shared
+          # download/build entry points change.
+          # The shared source bundle can predate vars in the PR, so explicitly
+          # fetch Arrow's bundled source dependencies before the targeted 
build.
+          if [[ "${{ steps.filter.outputs.arrow_paimon_changes }}" == "true" 
]]; then

Review Comment:
   [P1] Keep scheduled builds off the stale Arrow 17 prebuilt
   
   `Paths Filter` is skipped for `schedule`, so `arrow_paimon_changes` is empty 
and this branch never runs on the scheduled job. The current automation 
prebuilt used above contains `libarrow.a`, `libarrow_dataset.a`, and 
`libarrow_acero.a` but no `libarrow_compute.a` (and its source bundle still 
contains Arrow 17); only this PR-triggered branch installs 
`libarrow_compute.a`. Once the unconditional Compute import in 
`be/cmake/thirdparty.cmake` lands, scheduled master builds—and later BE-only 
PRs that do not set this filter—will try to link against that stale archive and 
fail. Please either regenerate/publish the version-matched prebuilt before 
landing and validate its Arrow version, or rebuild the Arrow/Paimon closure on 
the scheduled path as well. This is separate from the existing xsimd thread 
because scheduled runs never reach the targeted rebuild at all.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to