wenzhenghu commented on PR #65126: URL: https://github.com/apache/doris/pull/65126#issuecomment-5141795381
Follow-up update for the retained ID-map cleanup review (`discussion_r3681246479`): commit `8fe375d3275` now completes both prerequisites for safe constant-time cleanup. - HMS database event IDs are derived from the canonical local database name, so event registration and full loading use the same logical identity. - Database and table retained-ID state now uses a strict bidirectional `IdNameIndex`. - Targeted DROP/rename/replay cleanup removes the exact canonical-name mapping in O(1), replacing the previous full `entrySet().removeIf(...)` scan under the publication/database locks. - Conflicting `id <-> name` publication fails before either index side or the object cache is mutated. - Existing `MetaCacheEntry` action fencing continues to order ID-index publication with object publication and invalidation. Focused FE validation passed: `IdNameIndexTest`, `ExternalDatabaseTest`, `ExternalCatalogTest`, and `RefreshManagerTest` (95 tests, 0 failures/errors), plus FE checkstyle and `git diff --check`. The inline review has been updated. Issue #65779 has also been updated to mark this sub-item complete; it remains open because it tracks additional independent name-snapshot and extreme-cold lookup performance work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
