wenzhenghu commented on issue #65779: URL: https://github.com/apache/doris/issues/65779#issuecomment-5141794073
### Status update: retained ID-map cleanup is fixed The retained database/table ID-map cleanup item reported in PR #65126 review thread [discussion_r3681246479](https://github.com/apache/doris/pull/65126#discussion_r3681246479) has been fixed by commit [`8fe375d3275`](https://github.com/apache/doris/commit/8fe375d3275dcba7c2ad67ca1291a91e740370ac). The implementation replaces the one-way maps and `entrySet().removeIf(...)` scans with a strict bidirectional `IdNameIndex`. Targeted cleanup by canonical local name now removes the exact reverse-indexed pair in O(1), while publication/invalidation ordering remains coordinated with `MetaCacheEntry`. The same change canonicalizes database event IDs and rejects conflicting ID/name identities before cache mutation. Validation completed: - `IdNameIndexTest` - `ExternalDatabaseTest` - `ExternalCatalogTest` - `RefreshManagerTest` - 95 tests, 0 failures/errors - FE checkstyle - `git diff --check` This closes only the retained ID-map cleanup sub-item. The issue should remain open for the independent costs still listed in its main scope, especially `NameCacheValue.withName()/withoutLocalName()` full immutable-snapshot rebuilding, the bounded-delta/structural-sharing follow-up, and the remaining mode-2 extreme-cold fallback scan. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
