github-actions[bot] commented on code in PR #66297:
URL: https://github.com/apache/doris/pull/66297#discussion_r3690853056
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/metacache/paimon/PaimonLatestSnapshotProjectionLoader.java:
##########
@@ -79,8 +125,17 @@ private PaimonSnapshot resolveLatestSnapshot(Table
paimonTable) {
// Pin the data snapshot for MVCC while retaining the latest table
schema. A normal
// copy applies time travel and falls back to the snapshot's
schema, which can be stale
// immediately after a schema change that has not produced a new
data snapshot.
- snapshotTable = latestSchemaTable.copyWithoutTimeTravel(
-
Collections.singletonMap(CoreOptions.SCAN_SNAPSHOT_ID.key(),
String.valueOf(latestSnapshotId)));
+ Map<String, String> projectionOptions =
PaimonReaderOptions.runtimeSafeCopyOptions(
Review Comment:
[P1] Keep the lightweight latest fence neutral until relation options are
composed. Every selector-free OPTIONS relation now creates this fence before
calling the relation-aware overload. Here the copy map contains only the
injected snapshot selector, so runtimeSafeCopyOptions falls through to
collectManifestParallelism(latestSchemaTable) and rejects a physical
scan.manifest.parallelism=0. The later @options(...='1') map in the fenced
PaimonExternalTable.loadSnapshot overload is therefore unreachable, even though
the checked-in ordinary and system-table regressions expect that safe override
to succeed (empty latest takes the same early path). This is a new fence-stage
failure after the cache/preload fixes, not the same site as those threads.
Capture only snapshot/schema identity here, then normalize after the relation
projection is composed; cover StatementContext.loadSnapshots with a real
physical-0/relation-1 table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
