github-actions[bot] commented on code in PR #66313: URL: https://github.com/apache/doris/pull/66313#discussion_r3694601306
########## docker/thirdparties/docker-compose/hive/README.md: ########## @@ -60,6 +60,7 @@ Modules are refreshed incrementally: only modules whose content SHA changed are | `test` | `scripts/data/test/` | Lightweight smoke-test datasets | | `preinstalled_hql` | `scripts/create_preinstalled_scripts/*.hql` | ~77 HQL files, executed in parallel via `xargs -P` | | `view` | `scripts/create_view_scripts/create_view.hql` | View definitions | +| `paimon_hms` | `scripts/create_external_paimon_scripts/create_paimon_tables.hql` | Paimon tables registered in HMS (`hdfs_db`, `ali_db`, …); only selected when `enablePaimonHms=true` | Review Comment: [P2] Clarify that the flag gates only automatic selection. `normalize_hive_modules` intentionally still emits `paimon_hms` when a caller explicitly uses `--hive-modules paimon_hms` with `enablePaimonHms=false` (the related PR also calls this override out as a tested contract), so ‘only selected when’ is not true for the supported scoped-refresh path. Please say that the flag controls inclusion in the default/`all` expansion and document the explicit override here and in `README_ZH.md`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
