github-actions[bot] commented on code in PR #66012:
URL: https://github.com/apache/doris/pull/66012#discussion_r3703062736
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/iceberg/IcebergUtils.java:
##########
@@ -766,12 +766,22 @@ public static Map<String, String>
getPartitionInfoMap(PartitionData partitionDat
}
public static List<String> getIdentityPartitionColumns(Table table) {
+ return getIdentityPartitionColumns(table, false, false);
+ }
+
+ public static List<String> getIdentityPartitionColumns(Table table,
+ boolean enableMappingVarbinary, boolean enableMappingTimestampTz) {
LinkedHashSet<String> partitionColumns = new LinkedHashSet<>();
for (PartitionSpec spec : table.specs().values()) {
for (PartitionField partitionField : spec.fields()) {
if (!partitionField.transform().isIdentity()) {
continue;
}
+ NestedField sourceField =
table.schema().findField(partitionField.sourceId());
+ if (sourceField == null || !isSupportedPartitionValueType(
Review Comment:
[P1] Resolve partition names from the pinned scan schema
These helpers resolve source IDs through latest `table.schema()`, although
explicit snapshot/branch planning builds the scan descriptor from the selected
schema. For example, let S1 contain regular ID 1 `x` and identity-partition ID
2 `p`, then rename ID 1 to `y` and ID 2 to `x`. A query of S1 still projects ID
1 as `x`, but this code emits ID 2's partition value under `x`. Name-based FE
classification then marks the pinned ID-1 slot as a partition key; legacy
filling and FileScannerV2's constant precedence both return ID 2's value
instead of ID 1's data. Please pass the statement-pinned Iceberg schema that
produced the descriptor into these helpers, with v1/v2 time-travel
rename/name-reuse coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
