gavinchou commented on code in PR #66154:
URL: https://github.com/apache/doris/pull/66154#discussion_r3706179154
##########
fe/fe-core/src/main/java/org/apache/doris/persist/EditLog.java:
##########
@@ -1683,16 +1686,23 @@ private synchronized long logEditDirectly(short op,
Writable writable) {
// get a new transactionId
txId++;
- if (txId >= Config.edit_log_roll_num) {
- LOG.info("txId {} is equal to or larger than edit_log_roll_num {},
will roll edit.", txId,
- Config.edit_log_roll_num);
+ if (txId >= Config.edit_log_roll_num ||
exceedCloudEditLogRollInterval()) {
+ LOG.info("edit log roll condition met. txId: {}, edit log roll
num: {}, "
+ + "cloud edit log roll interval: {} seconds",
+ txId, Config.edit_log_roll_num,
Config.cloud_edit_log_roll_interval_second);
rollEditLog();
txId = 0;
}
return logId;
}
+ private boolean exceedCloudEditLogRollInterval() {
Review Comment:
just make the name mode independent,
it is actually not related to modes.
however, just useful in cloud mode by accident...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
