Gabriel39 commented on code in PR #66399:
URL: https://github.com/apache/doris/pull/66399#discussion_r3708907827
##########
be/src/exec/scan/file_scanner_v2.cpp:
##########
@@ -99,7 +101,11 @@ bool is_supported_table_format(const TFileRangeDesc& range)
{
return false;
}
return table_format == "NotSet" || table_format == "tvf" || table_format
== "hive" ||
- table_format == "iceberg" || table_format == "paimon" ||
table_format == "hudi";
+ table_format == "iceberg" || table_format == "paimon" ||
table_format == "hudi" ||
+ // A lake split of a fluss primary-key table read as its lake plus
its log tail. It is the
Review Comment:
[P2] Please handle the legacy-scanner selection explicitly. All Fluss reader
dispatch added by this PR exists only in `FileScannerV2`, but
`FileScanLocalState::_should_use_file_scanner_v2` still honors
`enable_file_scanner_v2=false`; in that supported session configuration the
scan falls into `FileScanner`, whose `FORMAT_JNI` dispatch has no
`fluss`/`fluss_union` branch and returns `Not supported create reader for table
format`. Either force V2 for Fluss ranges (if the variable is only a preference
for scans supported by both implementations), or fail during planning with a
clear requirement; add a test with the variable disabled so this does not
remain a late BE runtime surprise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
