github-actions[bot] commented on code in PR #66404: URL: https://github.com/apache/doris/pull/66404#discussion_r3709001590
########## .github/workflows/code-checks.yml: ########## @@ -1,155 +0,0 @@ -# Licensed to the Apache Software Foundation (ASF) under one -# or more contributor license agreements. See the NOTICE file -# distributed with this work for additional information -# regarding copyright ownership. The ASF licenses this file -# to you under the Apache License, Version 2.0 (the -# "License"); you may not use this file except in compliance -# with the License. You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, -# software distributed under the License is distributed on an -# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY -# KIND, either express or implied. See the License for the -# specific language governing permissions and limitations -# under the License. - -name: Code Checks - -on: [push, pull_request_target] - -jobs: - shellcheck: - name: ShellCheck - runs-on: ubuntu-latest - steps: - - name: Checkout ${{ github.ref }} ( ${{ github.sha }} ) - if: ${{ github.event_name != 'pull_request_target' }} - uses: actions/checkout@v3 - - - name: Checkout ${{ github.ref }} ( ${{ github.event.pull_request.head.sha }} ) - if: ${{ github.event_name == 'pull_request_target' }} - uses: actions/checkout@v3 - with: - ref: ${{ github.event.pull_request.head.sha }} - - - name: Checkout action-sh-checker - run: | - rm -rf ./.github/actions/action-sh-checker - git clone https://github.com/luizm/action-sh-checker .github/actions/action-sh-checker - - pushd .github/actions/action-sh-checker &>/dev/null - git checkout 76ab0b22e1f194e4a582edc7969df6485c4e9246 - sed -i 's/\[ "$GITHUB_EVENT_NAME" == "pull_request" \]/\[\[ "$GITHUB_EVENT_NAME" == "pull_request" || "$GITHUB_EVENT_NAME" == "pull_request_target" \]\]/' entrypoint.sh - popd &>/dev/null - - - name: Run ShellCheck - uses: ./.github/actions/action-sh-checker - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - with: - sh_checker_comment: true - sh_checker_exclude: .git .github ^docker/compilation ^docker/runtime ^thirdparty/src ^thirdparty/installed ^ui ^docs/node_modules ^tools/clickbench-tools ^extension ^output (^|.*/)Dockerfile$ ^be/src/apache-orc ^be/src/clucene ^pytest ^samples Review Comment: `build-support/shell-check.sh` still reads this exact `sh_checker_exclude` line from `.github/workflows/code-checks.yml` in `find_shell_scripts()`. Once this file is deleted, that `grep` hits a missing file and, under the helper's `set -e`, the helper exits before running ShellCheck or shfmt. Please move the exclusions into a surviving config/script and update `build-support/shell-check.sh` in this PR so the repository's shell-check entry point remains usable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
