englefly commented on code in PR #66354:
URL: https://github.com/apache/doris/pull/66354#discussion_r3710297884
##########
fe/fe-core/src/test/java/org/apache/doris/nereids/cost/CostModelV1Test.java:
##########
@@ -39,4 +53,28 @@ void testMaterializingCost() {
.getBestPlanTree();
p.anyMatch(j -> j instanceof PhysicalHashJoin && ((PhysicalHashJoin<?,
?>) j).getJoinType().isRightJoin());
}
+
+ @Test
+ void testPartitionedScalarAggregateCostUsesClusterScale() {
Review Comment:
1. 缺少反向用例。新测试只覆盖"partitionExpressions 非空 ⇒ /beNumber"，未覆盖：
- partitionExpressions 为空/空列表时 factor 仍为 1（select sum(x) from t
这类真正单点全局聚合，防回归）；
- groupBy 非空的既有行为（factor=beNumber）。
建议在同一测试中补两个断言（beNumber=4 时分别为 1000 和 250），防止后续改动误把单点聚合并行为并行。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
