github-actions[bot] commented on code in PR #66221:
URL: https://github.com/apache/doris/pull/66221#discussion_r3710897667
##########
thirdparty/build-thirdparty.sh:
##########
@@ -1088,9 +1090,7 @@ build_arrow() {
ldflags="-L${TP_LIB_DIR}"
fi
- CPPFLAGS="-I${TP_INCLUDE_DIR}" \
- CXXFLAGS="-I${TP_INCLUDE_DIR}" \
- LDFLAGS="${ldflags}" \
+ LDFLAGS="${ldflags}" \
Review Comment:
Withdrawn: this is not a PR regression. Arrow 24's `parquet_objlib` links
`thrift::thrift`, and that imported target exports `${TP_INSTALL_DIR}/include`
from the configured `Thrift_ROOT`. The compile therefore retains a path that
resolves `<lzo/lzo1x.h>` after the command-local flags are removed. The
original comment overlooked this transitive compile usage requirement.
##########
thirdparty/patches/apache-arrow-24.0.0-paimon.patch:
##########
@@ -40,26 +36,23 @@ index 285e2a5973..aa6f92f077 100644
this]() mutable -> ::arrow::Result<RecordBatchIterator> {
::arrow::ChunkedArrayVector columns(readers.size());
-- // don't reserve more rows than necessary
+ // don't reserve more rows than necessary
- int64_t batch_size = std::min(properties().batch_size(), num_rows);
- num_rows -= batch_size;
+ int64_t batch_size = 0;
+ if (!num_rows.empty()) {
-+ // don't reserve more rows than necessary
+ batch_size = std::min(properties().batch_size(),
num_rows[row_group_idx]);
+ num_rows[row_group_idx] -= batch_size;
-+ if (num_rows[row_group_idx] == 0 && (num_rows.size() - 1) !=
row_group_idx) {
-+ row_group_idx++;
++ if (num_rows[row_group_idx] == 0 && row_group_idx + 1 <
num_rows.size()) {
Review Comment:
Withdrawn: this is not introduced by this PR. The base Arrow 17 patch
already has the same per-row-group zero-count/advance behavior, and Arrow 17
`WriteTable` already writes a zero-row group for an empty table. The changed
condition here is semantically equivalent, so this review cannot attribute the
inherited limitation to the Arrow 24 upgrade.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
