github-actions[bot] commented on code in PR #65446:
URL: https://github.com/apache/doris/pull/65446#discussion_r3711368040
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/plugin/PluginDrivenExternalCatalog.java:
##########
@@ -247,6 +253,17 @@ public boolean validatePropertiesBeforeUpdate(
return true;
}
+ private void checkHiveParquetTimeZone(CatalogProperty property) throws
DdlException {
+ String catalogType = getType();
+ if ("hms".equalsIgnoreCase(catalogType) ||
"hudi".equalsIgnoreCase(catalogType)) {
Review Comment:
[P2] Validate time zones for opted-in custom providers
This helper still validates only the literal `hms`/`hudi` catalog types,
while `PluginDrivenScanNode` now deliberately lets any scan provider opt into
`usesHiveParquetInt96TimeZone()` and then parses this same property. For
example, a `corp_hive` provider that enables the capability and uses the
default no-op `ConnectorProvider.validateProperties()` can CREATE or ALTER with
`hive.parquet.time-zone=CST`; the value is accepted and journaled here, but the
first query later fails in `getConfiguredHiveParquetTimeZone()`. This is
distinct from the earlier valid custom-value routing issue: consumption now
follows the provider capability, but validation still follows hard-coded type
names. Please move validation to the owning provider/capability contract (for
both CREATE and ALTER), or otherwise validate every opted-in provider, and add
a custom-type invalid-value regression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
