HappenLee commented on PR #66442: URL: https://github.com/apache/doris/pull/66442#issuecomment-5178474571
Self-review: no blocking findings. - Goal and proof: the comparison result is normalized from const(nullable Boolean) to const(non-nullable Boolean), mapping SQL NULL according to NULLS FIRST/LAST. The new test covers execute_column and execute_filter in both modes. - Scope: limited to vtopn_pred.h and runtime_predicate_test.cpp; no unrelated refactoring. - Concurrency: no shared-state or synchronization changes; normalization only mutates the per-execution result column. - Lifecycle and ownership: no new long-lived references. IColumn::mutate is used once on the owned result, and returned ColumnPtr values retain nested-column ownership. - Configuration: no configuration or default changes. - Compatibility: no public symbol, RPC/protocol, or storage-format changes; rolling upgrades are unaffected. - Parallel paths and conditions: documented legal result shapes are covered recursively for ColumnConst, directly for ColumnNullable, and unchanged for non-nullable Boolean columns. The no-bound all-pass path is unchanged. - Tests: GLIBC_COMPATIBILITY=OFF ./run-be-ut.sh -j 48 --run --filter=RuntimePredicateTest.* passed all 11 tests after rebasing onto the latest apache/master. - Test artifacts: no golden/result files are added or modified. - Observability: no new persistent state or operational failure mode requiring logs or metrics. - Transactions, persistence, and writes: not applicable; this is a read-side runtime filter result transformation. - FE/BE variables: no cross-layer variable or semantic changes. - Performance: no materialization of full constant columns; the const path processes its single nested value, while non-const nullable work remains linear in row count. - Static checks: clang-format 16.0.6 check passed, git diff --check passed, and clang-tidy passed for both changed files with no warnings. - Other findings: none. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
