u70b3 commented on PR #66080: URL: https://github.com/apache/doris/pull/66080#issuecomment-5178951605
I implemented the same fix independently before noticing this PR — the approach here looks right to me. Worth calling out: `getTableNamesWithLock()` over `getTableNamesOrEmptyWithLock()` is the right choice — OrEmpty would turn name-conflict and remote init failures into a silently empty result, while the old `getTables()` path surfaces those errors to the user. One gap: no unit test. I have a Mockito-based test class covering the fast path (verifies `getTables()` is never called), LIKE/privilege filters, and the unchanged verbose/view/internal paths. I'll open a PR against your branch with it — you're welcome to merge it into this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
