github-actions[bot] commented on code in PR #66451:
URL: https://github.com/apache/doris/pull/66451#discussion_r3714394783
##########
fe/fe-core/src/main/java/org/apache/doris/cloud/catalog/CloudTabletRebalancer.java:
##########
@@ -523,7 +523,11 @@ protected void runAfterCatalogReady() {
indexBalanced = true;
tableBalanced = true;
- performBalancing();
+ try {
Review Comment:
[P2] Extend the cleanup fence over route rebuild and migration
`statRouteInfo()` has already populated the four large nested indexes before
this `try`, and `migrateTabletsForSmoothUpgrade()` runs outside it.
`migrateTablets()` deliberately rethrows edit-log and watershed-registration
failures, so either failure escapes to `Daemon.run()`, which sleeps without
invoking `releaseSchedulingIndexes()`; the newly rebuilt graphs remain retained
for the whole interval. This leaves the stated all-exit-path memory fix
incomplete on the smooth-upgrade path. Start the `try` before the first
`statRouteInfo()` (covering the optional second rebuild and balancing) and keep
the release in its `finally`; a lifecycle test that injects the migration
failure would exercise the production fence.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
