Gabriel39 commented on code in PR #66345:
URL: https://github.com/apache/doris/pull/66345#discussion_r3717619975
##########
fe/fe-connector/fe-connector-spi/src/main/java/org/apache/doris/connector/spi/write/ConnectorWritePlanProvider.java:
##########
@@ -98,6 +98,25 @@ default List<ConnectorWriteSortColumn>
getWriteSortColumns(ConnectorSession sess
return null;
}
+ /**
+ * Resolves write-sort positions against the bind-time target schema.
Connectors with stable field
+ * identities should override this form; the default preserves existing
name/ordinal behavior.
+ */
+ default List<ConnectorWriteSortColumn>
getWriteSortColumns(ConnectorSession session,
+ ConnectorTableHandle tableHandle, List<ConnectorColumn>
boundTargetColumns) {
+ return getWriteSortColumns(session, tableHandle);
+ }
+
+ /**
+ * Returns an opaque identity for metadata that shapes the physical write
plan. The engine captures it
+ * while binding the sink and returns it through {@link
ConnectorWriteHandle}; connectors can reject the
+ * write if a later metadata refresh would make that physical plan stale.
Default: {@code null} when the
+ * connector has no such metadata fence.
+ */
+ default String getWriteMetadataIdentity(ConnectorSession session,
ConnectorTableHandle tableHandle) {
Review Comment:
Fixed. After rebasing onto the current connector API baseline, this change
bumps the connector plugin API major from 4.0 to 5.0, regenerates the surface
baseline, and adds ConnectorTableSchema and ConnectorWriteHandle to the frozen
surface coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
